Use new CMake Python discovery, with matching Boost::Python abi. #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake has a new Python discovery module, that can also export major/minor version numbers. Switch to using it. Boost, has also moved on to standard pythonXY abi component name across all distributions/OS, thus use matching version ABI. If one wants to compile against much older Boost, I guess we could add fallback to search for Boost python3 component, but IMHO this should not be necessory.
|
Very cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake has a new Python discovery module, that can also export
major/minor version numbers. Switch to using it.
Boost, has also moved on to standard pythonXY abi component name
across all distributions/OS, thus use matching version ABI.
If one wants to compile against much older Boost, I guess we could add
fallback to search for Boost python3 component, but IMHO this should
not be necessory.