use require for NoError

Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
mkieweg · Jun 25, 2024 · 1be8574 · 1be8574
1 parent 0dc0a92
commit 1be8574
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/controller/appcontroller_test.go b/controller/appcontroller_test.go
@@ -1582,7 +1582,7 @@ apps/Deployment:
 
 			ctrl.processAppRefreshQueueItem()
 			apps, err := ctrl.appLister.List(labels.Everything())
-			assert.NoError(t, err)
+			require.NoError(t, err)
 			assert.NotEmpty(t, apps)
 			assert.Equal(t, tc.expectedStatus, apps[0].Status.Health.Status)
 			assert.NotEqual(t, testTimestamp, apps[0].Status.Health.LastTransitionTime)

diff --git a/controller/health_test.go b/controller/health_test.go
@@ -152,7 +152,7 @@ func TestSetApplicationHealth_HealthImproves(t *testing.T) {
 
 		t.Run(string(fmt.Sprintf("%s to %s", tc.oldStatus, tc.newStatus)), func(t *testing.T) {
 			healthStatus, err := setApplicationHealth(resources, resourceStatuses, overrides, app, true)
-			assert.NoError(t, err)
+			require.NoError(t, err)
 			assert.Equal(t, tc.newStatus, healthStatus.Status)
 			assert.NotEqual(t, healthStatus.LastTransitionTime, timestamp)
 		})

diff --git a/controller/state_test.go b/controller/state_test.go
@@ -750,7 +750,7 @@ func TestPreserveStatusTimestamp(t *testing.T) {
 	revisions := make([]string, 0)
 	revisions = append(revisions, "")
 	compRes, err := ctrl.appStateManager.CompareAppState(app, &defaultProj, revisions, sources, false, false, nil, false, false)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	assert.Equal(t, health.HealthStatusHealthy, compRes.healthStatus.Status)
 	assert.Equal(t, timestamp, compRes.healthStatus.LastTransitionTime)