Skip to content

Commit

Permalink
remove obsolete assert
Browse files Browse the repository at this point in the history
Signed-off-by: Manuel Kieweg <mail@manuelkieweg.de>
  • Loading branch information
mkieweg committed Jul 2, 2024
1 parent cac486a commit ed48e58
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions controller/appcontroller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ func (m *MockKubectl) DeleteResource(ctx context.Context, config *rest.Config, g
func newFakeController(data *fakeData, repoErr error) *ApplicationController {
return newFakeControllerWithResync(data, time.Minute, repoErr)
}

func newFakeControllerWithResync(data *fakeData, appResyncPeriod time.Duration, repoErr error) *ApplicationController {
var clust corev1.Secret
err := yaml.Unmarshal([]byte(fakeCluster), &clust)
Expand Down Expand Up @@ -1620,6 +1621,7 @@ apps/Deployment:
})
}
}

func TestUpdateHealthStatusProgression(t *testing.T) {
app := newFakeAppWithHealthAndTime(health.HealthStatusDegraded, testTimestamp)
deployment := kube.MustToUnstructured(&v1.Deployment{
Expand Down
1 change: 0 additions & 1 deletion controller/health_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ func TestSetApplicationHealth_ResourceHealthNotPersisted(t *testing.T) {
assert.Equal(t, health.HealthStatusDegraded, healthStatus.Status)

assert.Nil(t, resourceStatuses[0].Health)
assert.False(t, healthStatus.LastTransitionTime.IsZero())
}

func TestSetApplicationHealth_MissingResource(t *testing.T) {
Expand Down

0 comments on commit ed48e58

Please sign in to comment.