Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded minimatch and Glob to the latest major versions 3.x and 7.x #23

Closed
wants to merge 1 commit into from

Conversation

riy
Copy link

@riy riy commented Mar 2, 2016

Somewhere down the (latest) Karma test runner dependency path fileset is referenced but due to the (relatively old) glob@5.x version used an update fails. Hence this fork.

@mklabs
Copy link
Owner

mklabs commented Jun 1, 2016

Hi @riy, as mentioned in #22 I'll update fileset code and dependencies today and follow up with a publish to the registry.

I'll take care of conflicts and merge your commit. Thanks!

@riy
Copy link
Author

riy commented Jun 1, 2016

Thanks, @mklabs, much appreciated, but I now favor @isaacs's PR, as he's using SemVer the right way (it should be ^7.0.0 instead of ^6.0.3 though) :-)

@mklabs
Copy link
Owner

mklabs commented Jun 1, 2016

@riy Thanks! Currently working on updating the tests, will bump glob to 7.0.

As Isaacs detailed in commit message, the upgrade to glob 6 may or may not be a breaking change. So I'll just bump to 1.0. I'm also automatically ignoring node_modules in the sync api.

@mklabs mklabs closed this Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants