-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiny-lr v1 #103
Comments
👍 The dashboard is a great idea. Just let me know if I can help! Thanks! |
Hey @shama, glad you like the dashboard idea, I was aiming to use bel and yoyo to build it :p Actually, your help would be invaluable. I started working on it yesterday and did most of the work to refresh the code base into es6, reviewed the build process and tests, put eslint with standard config, etc. It's up on the dev branch if you'd like to take a look. I also just started the CLI, which spawns the server for now. |
This seems like a great list so far! As I noted on the other issue, my OSS time is limited for a few months, but I'm happy to help review PRs for sanity checks in the meantime. |
@elwayman02 No worries. I'm more than happy with just feedbacks. Plus, it is probably a long term effort, plenty of times to contribute. |
cc @hemanth |
@mklabs What's the plan for the Dashboard? (You have a specific design in your mind?) |
Yep, I can try to photoshop a mockup quickly. But we can start with no design at all, or just go with getmdl.io I really like their fwk |
we could use https://github.com/GoogleChrome/big-rig#big-rig app as a starting point (https://getmdl.io/templates/dashboard/index.html) also the hot stuff I've seen recently on the chrome remote protocol made me think about some interresting livereload options for chrome. |
So we would need this to be the dashboard or |
I think |
The main tech issue with dashboard is getting informations about tiny lr state and asking for a web socket connection. Will need major rewrite to both client / server side code. And we'd need to init the livereload js fork. |
or be lazy :p https://github.com/joewalnes/websocketd |
I would like the rewrite ;) [If the todo part of dash board becomes more granular, I can be bit lazy ;)] |
We might try to implement something similar than livereactload. I know it doesn't need to add a script tag to the page, and use browserify / babel transforms and plugins to establish a simple WS connection. |
Could use module-deps and something similar for CSS to build require tree, automatically watch with gaze, on code change trigger a watchify change, then trigger POST request to tiny-lr and dashboard. |
I'll start the dashboard package / repo soon. Will keep you posted @hemanth |
Hi @shama @hemanth @elwayman02 I hope you're all doing well. I started working on the dashboard for the last few days, I just wanted to let you know with a little screenshot :). Right now, this is pretty basic and still very wip It is able to list connected devices (testing with just browser tabs for now) by using socket.io to add / remove "cards" when client are created or destroyed. I'm still wondering how far the dashboard should go and how we might organise the codebase. Right now, the cli code is within the package but it should definitely go into a separate package (too much added dependencies) I'm also wondering if we should replace the livereloadjs code with something like livereactload. |
livereactload seems specifically geared to a single framework. On Fri, Aug 12, 2016, 3:36 AM Mickael Daniel notifications@github.com
|
Hi Jordan,thanks for the feedback. I used it briefly on the past. From my understanding, it is designed for react but can work for any kind of code I guess (at least js). That being said, I got the dashboard running and working with livereloadjs and basic watching with glob and gaze. I assume it is enough for now (even though I really like this idea of hot reloading). |
Maybe create a separate issue to discuss it and lay out the pros & cons of On Fri, Aug 12, 2016, 9:23 AM Mickael Daniel notifications@github.com
|
Yep sure. Done with #107 |
Nice start! Thanks, I am doing well, hoping the same there. |
I quite like how tiny tiny-lr is - could all these new features show up in other modules, leaving this tiny server here? |
@TehShrike I appreciate your feedback. Don't worry, it will remain the same. Actually all these v1 features have ended with the ES6 rewrite. And the dashboard part have been done in another module. |
For future reference: 'Fork livereload-js, port it to es6 / babel' is taking place in the livereload-js repo. |
@mklabs @elwayman02 I've published an |
@smhg Awesome. Thanks for letting us know. |
Last published version is 8 months old, and tiny-lr didn't really changed since its first implementation.
I'm thinking about a bunch of ideas and features, while keeping it tiny and focused. It should stay small (maybe try to make it even smaller) and suitable to use as a library.
**/*.{html,css}
. Handle .gitignore, ignore node_modules by default.-c 'npm test' -c 'gulp lint'
http://locahost:<lrport>
default JSON response.*.{js,css}
).cc @shama @elwayman02 What do you guys think ? Worth the effort ? Any other ideas or features you'd like to see implemented ?
The text was updated successfully, but these errors were encountered: