Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update livereload client (closes #132) #133

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Conversation

smhg
Copy link
Contributor

@smhg smhg commented Aug 4, 2020

No description provided.

@mr-wildcard
Copy link

mr-wildcard commented Aug 11, 2020

looking forward to that :)

Options.extract in livereload-js@^2 method is not reliable as it doesn't correctly parse the src attribute of the script containing /livereload.js (the port cannot be extracted for example).

@smhg
Copy link
Contributor Author

smhg commented Aug 13, 2020

@mr-wildcard that sound like it needs a solution.
Would you be willing to open an issue with an example in the livereload-js repo? Thanks!

@mr-wildcard
Copy link

@smhg this has already been fixed a long time ago in livereload-js@^3. I was just giving another reason to upgrade this tiny-lr dependency ;)

@elwayman02 elwayman02 merged commit 5753beb into mklabs:master Oct 9, 2020
@elwayman02
Copy link
Collaborator

@smhg are there any breaking changes between livereload 2 and 3?

@smhg
Copy link
Contributor Author

smhg commented Oct 9, 2020

The only thing I am aware of is the lack of ancient browser support (IE6-9).
Prior to v3 the library was built by the Coffeescript compiler and I have no idea how far back browser support went with those builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants