Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on OS X #10

Closed
edawson opened this issue Mar 14, 2019 · 2 comments
Closed

Build fails on OS X #10

edawson opened this issue Mar 14, 2019 · 2 comments

Comments

@edawson
Copy link

edawson commented Mar 14, 2019

I'm building tachyon on OS X using gcc 7.4 off the latest master branch, but it's failing to compile. The first error is here:

In file included from ./include/support_vcf.h:32:0,
                 from lib/support/support_vcf.cpp:1:
./include/buffer.h: In instantiation of 'void tachyon::SerializePrimitive(const T&, tachyon::yon_buffer_t&) [with T = long unsigned int]':
lib/support/support_vcf.cpp:206:36:   required from here
./include/buffer.h:161:9: error: ambiguous overload for 'operator+=' (operand types are 'tachyon::yon_buffer_t' and 'const long unsigned int')
  buffer += value;

There are then several errors of this type:

./include/buffer.h:166:9: error: cannot bind non-const lvalue reference of type 'double&' to an rvalue of type 'double'
  buffer >> value;

Is there a missing compiler flag perhaps? If it helps, most of the compiler errors seem to be in buffer.h.

@mklarqvist
Copy link
Owner

This is now fixed in the dev branch and will be merged shortly.

@mklarqvist
Copy link
Owner

Fixed in #12

mklarqvist added a commit that referenced this issue Apr 26, 2019
Resolves #11 and #10  and #7 . General code style clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants