added TODO comments for password prompts

mkloubert · Jun 2, 2017 · 976a1cc · 976a1cc
1 parent 40d139b
commit 976a1cc
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 3 deletions.
diff --git a/src/plugins/api.ts b/src/plugins/api.ts
@@ -99,6 +99,8 @@ class ApiPlugin extends deploy_objects.DeployPluginBase {
 
             let user = deploy_helpers.normalizeString(target.user);
             if (user) {
+                //TODO: password prompt
+
                 let pwd = deploy_helpers.toStringSafe(target.password);
 
                 headers['Authorization'] = `Basic ${(new Buffer(user + ':' + pwd).toString('base64'))}`;
@@ -277,6 +279,8 @@ class ApiPlugin extends deploy_objects.DeployPluginBase {
 
                 let user = deploy_helpers.normalizeString(target.user);
                 if (user) {
+                    //TODO: password prompt
+
                     let pwd = deploy_helpers.toStringSafe(target.password);
 
                     headers['Authorization'] = `Basic ${(new Buffer(user + ':' + pwd).toString('base64'))}`;

diff --git a/src/plugins/dropbox.ts b/src/plugins/dropbox.ts
@@ -125,6 +125,8 @@ class DropboxPlugin extends deploy_objects.DeployPluginWithContextBase<DropboxCo
             };
 
             try {
+                //TODO: password prompt (access token)
+
                 let ctx: DropboxContext = {
                     dir: dir,
                     hasCancelled: false,

diff --git a/src/plugins/ftp.ts b/src/plugins/ftp.ts
@@ -184,6 +184,7 @@ class FtpClient extends FtpClientBase {
         let port = parseInt(deploy_helpers.toStringSafe(target.port, isSecure ? '990' : '21').trim());
 
         let user = deploy_helpers.toStringSafe(target.user, 'anonymous');
+        //TODO: password prompt
         let pwd = deploy_helpers.toStringSafe(target.password);
 
         let rejectUnauthorized = target.rejectUnauthorized;
@@ -529,6 +530,7 @@ class JsFTPClient extends FtpClientBase {
         let port = parseInt(deploy_helpers.toStringSafe(target.port, isSecure ? '990' : '21').trim());
 
         let user = deploy_helpers.toStringSafe(target.user, 'anonymous');
+        //TODO: password prompt
         let pwd = deploy_helpers.toStringSafe(target.password);
 
         return new Promise<boolean>((resolve, reject) => {

diff --git a/src/plugins/http.ts b/src/plugins/http.ts
@@ -127,10 +127,11 @@ class HttpPlugin extends deploy_objects.DeployPluginBase {
 
             let user = deploy_helpers.toStringSafe(target.user);
             if (user) {
+                //TODO: password prompt
                 let pwd = deploy_helpers.toStringSafe(target.password);
 
                 headers['Authorization'] = 'Basic ' + 
-                                        (new Buffer(`${user}:${pwd}`)).toString('base64');
+                                           (new Buffer(`${user}:${pwd}`)).toString('base64');
             }
 
             let submitFileHeader = deploy_helpers.toBooleanSafe(target.submitFileHeader, false);

diff --git a/src/plugins/mail.ts b/src/plugins/mail.ts
@@ -76,6 +76,7 @@ class MailPlugin extends deploy_objects.ZipFileDeployPluginBase {
         let auth: any;
         let user = deploy_helpers.toStringSafe(target.user);
         if (user) {
+            //TODO: password prompt
             let password = deploy_helpers.toStringSafe(target.password);
 
             auth = {

diff --git a/src/plugins/sftp.ts b/src/plugins/sftp.ts
@@ -310,6 +310,9 @@ class SFtpPlugin extends deploy_objects.DeployPluginWithContextBase<SFTPContext>
             if ('' === user) {
                 user = undefined;
             }
+            else {
+                //TODO: password prompt
+            }
             let pwd = deploy_helpers.toStringSafe(target.password);
             if ('' === pwd) {
                 pwd = undefined;

diff --git a/src/sql.ts b/src/sql.ts
@@ -234,12 +234,15 @@ export function createMSSqlConnection(opts?: MSSqlOptions): Promise<MSSqlConnect
             }
 
             let user = deploy_helpers.toStringSafe(opts.user).trim();
-            if (!user) {
+            if ('' === user) {
                 user = 'sa';
             }
+            else {
+                //TODO: password prompt
+            }
 
             let pwd = deploy_helpers.toStringSafe(opts.password);
-            if (!pwd) {
+            if ('' === pwd) {
                 pwd = undefined;
             }