Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature request #41

Merged
merged 11 commits into from
Apr 11, 2023
Merged

Signature request #41

merged 11 commits into from
Apr 11, 2023

Conversation

mkslanc
Copy link
Owner

@mkslanc mkslanc commented Mar 13, 2023 •
edited
Loading

documentHighlights turned off until it would have basic functionality

mkslanc and others added 11 commits March 13, 2023 18:22
@mkslanc
add signatureHelp requests for default services (typescript for now)
2b77537
@mkslanc
add new tooltip type - Signature Tooltip
d2e9643
@mkslanc
Merge remote-tracking branch 'origin/main' into signature-request
182e02e 
# Conflicts:
#	packages/ace-linters/components/description-tooltip.ts
@mkslanc
fixed bug with active editor for hover - cherry-picked
5e5713d
@mkslanc
add Document Highlights Request for default services (typescript, css)
9f01996
@mkslanc
add tests for fromSignatureHelp
1369fa0
@mkslanc
add signatureHelp and documentHighlight requests for ace language…
3a2700d 
… client
@anijanyan
on activate editor remove previous editor mouseout event
ddc1c14
@mkslanc
mock $applyDocumentHiglight for now
6152569
@mkslanc
Merge remote-tracking branch 'origin/main' into signature-request
f8a90ca 
# Conflicts:
#	packages/ace-linters/components/description-tooltip.ts
#	packages/ace-linters/language-provider.ts
#	packages/demo/webworker-lsp/demo.ts
@mkslanc
add new features to functionality
9ca3e96
@mkslanc mkslanc requested a review from anijanyan April 11, 2023 15:59
@mkslanc mkslanc marked this pull request as ready for review April 11, 2023 15:59
@mkslanc mkslanc merged commit b14296d into main Apr 11, 2023
@anijanyan anijanyan deleted the signature-request branch June 1, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anijanyan anijanyan Awaiting requested review from anijanyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkslanc @anijanyan