Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Align Package Name with Directory Structure for vibrateFactory #109

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

abuciuman
Copy link
Contributor

Problem

During an analysis of the react-native-haptic-feedback library using the Android Analyzer, a discrepancy was identified between the package declaration and the corresponding directory structure. The error flagged was:

Package name 'com.mkuczera' does not correspond to the file path 'com.mkuczera.VibrateFactory'

This mismatch not only confuses code readers but also potentially disrupts some tools from working correctly. Such an inconsistency, although not strictly mandated by the Java language, is important to address to ensure consistency and optimal functionality across various toolchains and IDEs.

Solution

To address the highlighted inconsistency:

  1. Package Name Update: I changed the package name from com.mkuczera to com.mkuczera.vibrateFactory to better align with the class's purpose and ensure it matches its directory.

  2. Directory Structure Adjustment: The folder previously named VibrateFactory has been renamed to vibrateFactory (in camelCase) to reflect conventional Java naming standards and ensure alignment with the updated package name.

@abuciuman abuciuman changed the title Fix: Package name Refactor: Align Package Name with Directory Structure for vibrateFactory Aug 8, 2023
@mkuczera mkuczera merged commit b9890e1 into mkuczera:master Aug 15, 2023
@mkuczera
Copy link
Owner

Fixed in 2.1.0, currently in beta to test it. Thanks for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants