Refactor: Align Package Name with Directory Structure for vibrateFactory #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During an analysis of the
react-native-haptic-feedback
library using the Android Analyzer, a discrepancy was identified between the package declaration and the corresponding directory structure. The error flagged was:This mismatch not only confuses code readers but also potentially disrupts some tools from working correctly. Such an inconsistency, although not strictly mandated by the Java language, is important to address to ensure consistency and optimal functionality across various toolchains and IDEs.
Solution
To address the highlighted inconsistency:
Package Name Update: I changed the package name from
com.mkuczera
tocom.mkuczera.vibrateFactory
to better align with the class's purpose and ensure it matches its directory.Directory Structure Adjustment: The folder previously named
VibrateFactory
has been renamed tovibrateFactory
(in camelCase) to reflect conventional Java naming standards and ensure alignment with the updated package name.