This repository has been archived by the owner on Apr 20, 2024. It is now read-only.
Feature: Email validation #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinlasek
requested review from
steffendsommer,
siemensikkema and
BrettRToomey
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=========================================
- Coverage 47.74% 47.3% -0.45%
=========================================
Files 24 24
Lines 1066 1076 +10
Branches 23 23
=========================================
Hits 509 509
- Misses 557 567 +10
Continue to review full report at Codecov.
|
|
I will leave this for @siemensikkema as he has better overview of what can be re-used for this new piece of functionality. |
| @@ -57,6 +59,15 @@ open class APIUserControllerDelegate<U: JWTKeychainUser>: | |||
| passwordResetMailer: PasswordResetMailerType | |||
| ) throws -> ResponseRepresentable { | |||
| do { | |||
|
|
|||
There was a problem hiding this comment.
unnecessary newline (?)
| @@ -57,6 +59,15 @@ open class APIUserControllerDelegate<U: JWTKeychainUser>: | |||
| passwordResetMailer: PasswordResetMailerType | |||
| ) throws -> ResponseRepresentable { | |||
| do { | |||
|
|
|||
| if let json = request.json { | |||
| let email: String = try json.get("email") | |||
There was a problem hiding this comment.
I forget but isn't there a constant for the key "email" somewhere?
| @@ -87,4 +100,8 @@ extension APIUserControllerDelegate { | |||
| func status(_ status: String) -> ResponseRepresentable { | |||
| return JSON(["status": .string(status)]) | |||
| } | |||
|
|
|||
| enum EmailError: Error { | |||
There was a problem hiding this comment.
can this be private?
siemensikkema
approved these changes
Feb 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The email provided to reset password is not checked on valid format