Fix detokenizer space match for quote #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awni
commented
Oct 27, 2024
llms/mlx_lm/__init__.py
Outdated
Comment on lines
5
to
7
| import os | ||
| os.environ["TRANSFORMERS_NO_ADVISORY_WARNINGS"] = "1" | ||
|
|
There was a problem hiding this comment.
Get's rid of the warning:
None of PyTorch, TensorFlow >= 2.0, or Flax have been found. Models won't be available and only tokenizers, configuration and file/data utilities can be used.
hschaeufler
approved these changes
Oct 27, 2024
| from ._version import __version__ | ||
|
|
||
| os.environ["TRANSFORMERS_NO_ADVISORY_WARNINGS"] = "1" |
There was a problem hiding this comment.
Maybe a comment in the code would be nice, why you set the flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduces a bug when trying to port the
clean_up_tokenization_spacesfrom HF.Their match is actually to find and replace instances of
'with'. That one specifically requires a special case to post-process which is tedious, so I just removed that case as I have never seen it come up. But if it does we can revisit.For reference, the transformers matching conditions.
Closes #1073