Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spm decoder multi-byte #1092

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix spm decoder multi-byte #1092

merged 1 commit into from
Nov 5, 2024

Conversation

awni
Copy link
Member

@awni awni commented Nov 5, 2024

Closes #808

angeloskath
angeloskath approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@angeloskath angeloskath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@awni awni merged commit 6fd1f70 into main Nov 5, 2024
2 checks passed
@awni awni deleted the fix_spm_multibyte branch November 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloskath angeloskath angeloskath approved these changes

@barronalex barronalex Awaiting requested review from barronalex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPMStreamingDetokenizer sometimes outputs incorrect multi-byte characters
2 participants
@awni @angeloskath