Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds EXAONE architecture. #1145

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Adds EXAONE architecture. #1145

merged 5 commits into from
Dec 9, 2024

Conversation

N8python
Copy link
Contributor

@N8python N8python commented Dec 9, 2024

Verified on local device with 2.4B parameter model.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition! I enabled it for LoRA training as well.

@awni
Copy link
Member

awni commented Dec 9, 2024

Also fixed the RoPE (and refactored that a bit). It was using the wrong rope type.

@awni awni merged commit 5687d5b into ml-explore:main Dec 9, 2024
4 checks passed
mokeddembillel pushed a commit to mokeddembillel/mlx-examples that referenced this pull request Dec 16, 2024
* Adds EXAONE architecture.

* nits + format

* format

* clean up and fix rope

* clean up and fix rope

---------

Co-authored-by: Awni Hannun <awni@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants