Add support for cohere2 #1157
Merged
Add support for cohere2 #1157
+228
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: n8programs <43304488+N8python@users.noreply.github.com>
Add rotating kvcache to save space
|
Thanks @N8python! Verified this change saves ~2GB for 4bit: 
and ~1.2GB for bf16: |
Closed
awni
reviewed
Dec 16, 2024
Comment on lines
+86
to
+89
| if self.use_sliding_window and mask is not None: | ||
| key_len = keys.shape[-2] | ||
| if mask.shape[-1] != key_len: | ||
| mask = mask[..., -key_len:] |
There was a problem hiding this comment.
This changed slightly. You would be over trimming the keys/values during the prefill stage otherwise.
There was a problem hiding this comment.
Oh, I see.
I thought of this but it was giving me a shape error when I tried exactly this. Because I knew the make_cache was already handling the kv slicing when I checked the shapes.
...
===
window_size 4096
keys shape (1, 8, 4096, 128)
values shape (1, 8, 4096, 128)
mask shape after (512, 4096)
===
window_size 4608
keys shape (1, 8, 4608, 128)
values shape (1, 8, 4608, 128)
mask shape after (512, 4608)
===
window_size 4608
keys shape (1, 8, 4608, 128)
values shape (1, 8, 4608, 128)
mask shape after (512, 4608)
===
...
It seems like I should added the changes in mask (L158-163) that you added.
|
Our pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Cohere2 with sliding attention.
Thanks a lot to @N8python for the inspiration!
Bf16
4bit
