fix for #114 -- incorrect shape used in preload #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkoski
commented
Aug 30, 2024
| @@ -179,7 +179,7 @@ public struct TokenIterator: Sequence, IteratorProtocol { | |||
| // prepare the prompt in chunks if larger than the prefill size | |||
| while y.size > parameters.prefillStepSize { | |||
| _ = model( | |||
| y[..<parameters.prefillStepSize, .newAxis], cache: cache.isEmpty ? nil : cache) | |||
| y[.newAxis, ..<parameters.prefillStepSize], cache: cache.isEmpty ? nil : cache) | |||
There was a problem hiding this comment.
This code from python was translated incorrectly:
model(y[:prefill_step_size][None], cache=cache)should be:
y[.newAxis, ..<parameters.prefillStepSize]So this only hits the preload case (> 512 tokens) and curiously it seems to work fine with smaller preloads -- I was testing it with 32 token parameters.prefillStepSize and didn't encounter this.
Anyway, this was a bad problem because the shape of the input to attention was:
python: (1, 512, 3072)
swift: [512, 1, 3072]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.