update to pick up mlx v0.16.0 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkoski
commented
Jul 15, 2024
| FetchContent_MakeAvailable(mlx-c) | ||
|
|
||
| # TEMPORARY OVERRIDE -- 0.0.8 depends on v0.14.0 but we need v0.15.2 for iOS / | ||
| # float16 issues |
There was a problem hiding this comment.
I may have to add this back as mlx-c is for v0.15.2 but we need to build vs v0.16.0 for the Sequoia assert crashes
davidkoski
commented
Jul 15, 2024
|
|
||
| // the mlx-c side of distributed | ||
| "include/mlx/c/distributed.cpp", | ||
| "include/mlx/c/distributed_group.cpp", |
There was a problem hiding this comment.
This is now exposed on the mlx-c layer -- need to discuss how we expose this in swift and specifically how the build will work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mlx-c actually matches v0.15.2 but we want the Sequoia crash fixes from v0.16.0