Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for macOS 15 #1208

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Build for macOS 15 #1208

merged 3 commits into from
Jun 13, 2024

Conversation

awni
Copy link
Member

@awni awni commented Jun 13, 2024

Tests clear with:

  • macOS 15
  • Xcode 16.0
  • macOS SDK 15.0
  • Apple clang version 16.0.0

Compiler warnings:

/Users/awnihannun/mlx/mlx/backend/accelerate/matmul.cpp:110:9: warning: 'BNNSLayerParametersBroadcastMatMul' is deprecated: first deprecated in macOS 15.0 - Use BNNSGraph* APIs [-Wdeprecated-declarations]
  110 |   const BNNSLayerParametersBroadcastMatMul gemm_params{
      |         ^
/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk/System/Library/Frameworks/vecLib.framework/Headers/BNNS/bnns_structures.h:1391:3: note: 'BNNSLayerParametersBroadcastMatMul' has been explicitly marked deprecated here
 1391 | } BNNSLayerParametersBroadcastMatMul
      |   ^
/Users/awnihannun/mlx/mlx/backend/accelerate/matmul.cpp:178:7: warning: 'BNNSFilterCreateLayerBroadcastMatMul' is deprecated: first deprecated in macOS 15.0 - Use BNNSGraph* APIs [-Wdeprecated-declarations]
  178 |       BNNSFilterCreateLayerBroadcastMatMul(&gemm_params, nullptr);
      |       ^
/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk/System/Library/Frameworks/vecLib.framework/Headers/BNNS/bnns.h:269:12: note: 'BNNSFilterCreateLayerBroadcastMatMul' has been explicitly marked deprecated here
  269 | BNNSFilter BNNSFilterCreateLayerBroadcastMatMul(const BNNSLayerParametersBroadcastMatMul *layer_params,
      |            ^
/Users/awnihannun/mlx/mlx/backend/accelerate/matmul.cpp:181:5: warning: 'BNNSFilterApplyTwoInput' is deprecated: first deprecated in macOS 15.0 - Use BNNSGraph* APIs [-Wdeprecated-declarations]
  181 |     BNNSFilterApplyTwoInput(
      |     ^
/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk/System/Library/Frameworks/vecLib.framework/Headers/BNNS/bnns.h:541:5: note: 'BNNSFilterApplyTwoInput' has been explicitly marked deprecated here
  541 | int BNNSFilterApplyTwoInput(BNNSFilter filter,
      |     ^
/Users/awnihannun/mlx/mlx/backend/accelerate/matmul.cpp:190:3: warning: 'BNNSFilterDestroy' is deprecated: first deprecated in macOS 15.0 - Use BNNSGraph* APIs [-Wdeprecated-declarations]
  190 |   BNNSFilterDestroy(bnns_filter);
      |   ^
/Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.sdk/System/Library/Frameworks/vecLib.framework/Headers/BNNS/bnns.h:827:6: note: 'BNNSFilterDestroy' has been explicitly marked deprecated here
  827 | void BNNSFilterDestroy(BNNSFilter filter)
      |      ^
4 warnings generated.

@awni awni marked this pull request as draft June 13, 2024 16:11
@awni awni marked this pull request as ready for review June 13, 2024 18:29
@awni awni merged commit 31e134b into main Jun 13, 2024
3 checks passed
@awni awni deleted the macos15 branch June 13, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants