-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster cpu ops #1434
Faster cpu ops #1434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took some reading cause this moves some code that was added to fix an oob access in the copy. I am pretty sure it just moved further down in copy so no regression there let me know if I missed something.
Otherwise it looks great. Love to see all those red lines in the diff.
84e5890
to
2dbda67
Compare
Which code are you referring to? I can double check that I didn't mess that up. |
0, | ||
0, | ||
CopyType::General); | ||
copy_inplace(in, out, CopyType::General); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the diff I was referring to. Git commit 03cf033 .
dst, | ||
data_shape, | ||
i_strides, | ||
make_contiguous_strides<StrideT>(data_shape), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it should be fine due to that.
15ca8cd
to
8c2d612
Compare
Benchmarks
Everything is way faster up to arbitrary dimensions. A few benchmarks:
Note the copy is about the same because it had a 7D specialization. Now it only has up to 3D specialized.