Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased the timeouts to handle long PDFs gracefully #480

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

enoriega
Copy link
Member

Fixes #476

@enoriega enoriega added this to the [DARPA] Milestone 10 milestone Sep 15, 2023
@enoriega
Copy link
Member Author

@kwalcock Tested the docker image built locally and works!

@kwalcock
Copy link
Contributor

It looks very good to me. I read some of the assertions about the timeout not being respected in dev mode, and it looks like you found the solution. Thanks for getting to it before I did.

Does 40 minutes processing time indicate some other problem?

The CI has been failing on the docker container for me as well.

@enoriega
Copy link
Member Author

@kwalcock The 40 mins is just some arbitrary value, long enough to process a paper with many dozens of pages and accounting for COSMOS processing time.

CI is failing for something apparently unrelated. Not sure yet how to fix it

See if this fixes the CI issue
@github-actions github-actions bot added the CI continuous integration and automated workflows label Sep 15, 2023
@enoriega
Copy link
Member Author

@myedibleenso @kwalcock It seems that there is an issue in the free disk (aggressively) action of the GitHub workflow where it can't access an ubuntu repository correctly. I tried a couple variants of a fix I found online, but didn't succeed on fixing it. Do you have any leads on how to fix it?

@myedibleenso
Copy link
Collaborator

myedibleenso commented Sep 15, 2023

I think the CI issue is the same one reported here: jlumbroso/free-disk-space#9

... and this open PR fixes it: jlumbroso/free-disk-space#8

That one has been open for awhile. Why don't we try using the fork with the fix.

To do so in this case, I believe we just need to change the action name from jlumbroso/free-disk-space@<tag> to kfir4444/free-disk-space@main. Can you give that a shot, @enoriega ?

@enoriega
Copy link
Member Author

@myedibleenso Testing after applying the fix

@enoriega enoriega merged commit 692a405 into main Sep 15, 2023
6 checks passed
@enoriega enoriega deleted the enoriega/issue476 branch September 15, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix CI continuous integration and automated workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TextReading] Play! Web Service resets connection with client for long inputs
3 participants