Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handpose cleanup #196

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Handpose cleanup #196

merged 3 commits into from
Aug 29, 2024

Conversation

ziyuan-linn
Copy link
Member

This PR refactors the code of BodyPose. No functional changes.

  • update incorrect license info: MIT License -> ml5.js License.

  • add a file description and some helpful links at the beginning of the file.

  • clean up options object JSDoc comment.

  • move mold objects/schemas for handleOptions next to the options object comment.

  • add descriptions for the properties of HandPose

  • change wordings in comments for clarity

  • fix a small typo in BodyPose

@shiffman
Copy link
Member

Looks great, thank you!

@shiffman shiffman merged commit 41be997 into main Aug 29, 2024
@ziyuan-linn ziyuan-linn mentioned this pull request Aug 30, 2024
10 tasks
@ziyuan-linn ziyuan-linn deleted the handpose-cleanup branch September 15, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants