Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HandPose connections #226

Merged
merged 3 commits into from
Nov 1, 2024
Merged

HandPose connections #226

merged 3 commits into from
Nov 1, 2024

Conversation

ziyuan-linn
Copy link
Member

This PR implements the getConnections function for handPose and adds a skeletal connection example. See #224 for details.

One small question that remains is how shall we name the examples now that we are switching to getConnections instead of getSkeleton. The current examples are named modelName-skeleton. Perhaps we could rename them modelName-skeletal-connections?

@ziyuan-linn ziyuan-linn linked an issue Oct 29, 2024 that may be closed by this pull request
@ziyuan-linn ziyuan-linn changed the title Hand pose connections HandPose connections Oct 29, 2024
@shiffman
Copy link
Member

I think modelName-skeletal-connections is great!

@shiffman
Copy link
Member

shiffman commented Nov 1, 2024

Merging, yay!

@shiffman shiffman merged commit 308b786 into main Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HandPose Connections
2 participants