Skip to content

Commit

Permalink
[Scripts] Fix build_components (#332)
Browse files Browse the repository at this point in the history
This PR ensures that the `build_components.sh` script can run on both
Linux and MacOS.

As suggested by @RobbeSneyders
[here](#303 (comment)),
thanks!
  • Loading branch information
NielsRogge authored Aug 2, 2023
1 parent 4161b19 commit 8cb87fd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,7 @@ MANIFEST
*.tgz

# docker artifacts
examples/pipelines/**/docker-compose.yml
examples/pipelines/**/docker-compose.yml

# yaml-e files
*.yaml-e
2 changes: 1 addition & 1 deletion scripts/build_components.sh
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ for dir in "${components_to_build[@]}"; do

echo "Updating the image version in the fondant_component.yaml with:"
echo "${full_image_names[0]}"
sed -i "s|^image: .*|image: ${full_image_names[0]}|" fondant_component.yaml
sed -i -e "s|^image: .*|image: ${full_image_names[0]}|" fondant_component.yaml

args=()

Expand Down

0 comments on commit 8cb87fd

Please sign in to comment.