Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify cloud credential mounting in local runner #256

Closed
RobbeSneyders opened this issue Jul 3, 2023 · 1 comment
Closed

Simplify cloud credential mounting in local runner #256

RobbeSneyders opened this issue Jul 3, 2023 · 1 comment
Assignees
Labels

Comments

@RobbeSneyders
Copy link
Member

Currently the user needs to manually provide the location of the cloud credentials to mount with the local runner, which is quite complex. Eg:

fondant compile pipeline:pipeline --extra-volumes "$HOME/.config/gcloud/application_default_credentials.json:/root/.config/gcloud/application_default_credentials.json:ro"

These cloud credentials have a default location on the user system, so we could make it easier. We can either:

  • Automatically add them without the user having to specify anything. This is the simplest approach for the user, but would also mount the credentials when not needed, and could expose them to third party components.
  • Add a flag to add them, and use the default path. Eg.
    fondant compile pipeline:pipeline --auth-gcp
    

The user can still use the --extra-volumes argument to pass a non-default location.

@RobbeSneyders RobbeSneyders converted this from a draft issue Jul 3, 2023
@RobbeSneyders RobbeSneyders moved this from Ready for development to Backlog in Fondant development Oct 5, 2023
@RobbeSneyders RobbeSneyders moved this from Backlog to Breakdown in Fondant development Oct 22, 2023
@PhilippeMoussalli PhilippeMoussalli moved this from Breakdown to Ready for development in Fondant development Oct 24, 2023
@PhilippeMoussalli PhilippeMoussalli self-assigned this Oct 24, 2023
@PhilippeMoussalli PhilippeMoussalli moved this from Ready for development to Validation in Fondant development Oct 24, 2023
PhilippeMoussalli added a commit that referenced this issue Oct 25, 2023
PhilippeMoussalli added a commit that referenced this issue Oct 25, 2023
@RobbeSneyders
Copy link
Member Author

Closed in #548

@github-project-automation github-project-automation bot moved this from Validation to Done in Fondant development Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants