Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fondant explore to to accept a base path instead of a local path and handle path resolutions internally #426

Closed
Tracked by #424
PhilippeMoussalli opened this issue Sep 11, 2023 · 0 comments
Closed
Tracked by #424

Change fondant explore to to accept a base path instead of a local path and handle path resolutions internally #426

PhilippeMoussalli opened this issue Sep 11, 2023 · 0 comments
Assignees
@PhilippeMoussalli

Comments

@PhilippeMoussalli
Copy link
Contributor

No description provided.

@PhilippeMoussalli PhilippeMoussalli mentioned this issue Sep 11, 2023
Closed
@PhilippeMoussalli PhilippeMoussalli mentioned this issue Sep 11, 2023
Merged
PhilippeMoussalli added a commit that referenced this issue Sep 18, 2023
@PhilippeMoussalli
Handle different base paths explorer (#427)
32c8272 
Linked to #426 #424 

Previous implementation of the local runner could only work with a local
runner and not the remote one. This PR enables the explorer to handle
both. If the base path is local, it will be mounted to the explorer.
Otherwise, the base path will be passed as a container argument inside
the component

Notes: 
* Cloud credentials are optional for the local runner (manifest is local
but can point to a remote ) but mandatory with the remote base path
@PhilippeMoussalli PhilippeMoussalli moved this from Backlog to Done in Fondant development Oct 3, 2023
@PhilippeMoussalli PhilippeMoussalli self-assigned this Oct 3, 2023
Hakimovich99 pushed a commit that referenced this issue Oct 16, 2023
@PhilippeMoussalli
Handle different base paths explorer (#427)
2194eb4 
Linked to #426 #424 

Previous implementation of the local runner could only work with a local
runner and not the remote one. This PR enables the explorer to handle
both. If the base path is local, it will be mounted to the explorer.
Otherwise, the base path will be passed as a container argument inside
the component

Notes: 
* Cloud credentials are optional for the local runner (manifest is local
but can point to a remote ) but mandatory with the remote base path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippeMoussalli PhilippeMoussalli

Labels
None yet
Projects
Fondant development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobbeSneyders @PhilippeMoussalli