Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pandas interface #200

Merged
merged 11 commits into from
Jun 14, 2023
Merged

Add Pandas interface #200

merged 11 commits into from
Jun 14, 2023

Conversation

RobbeSneyders
Copy link
Member

@RobbeSneyders RobbeSneyders commented Jun 13, 2023

Fixes #183

There's some todo's left, we should

Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robbe :) looking nice!

Left a few comments and questions

fondant/component.py Show resolved Hide resolved
fondant/component.py Outdated Show resolved Hide resolved
fondant/component.py Show resolved Hide resolved
@RobbeSneyders RobbeSneyders marked this pull request as ready for review June 14, 2023 08:27
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robbe 👍

docs/custom_component.md Outdated Show resolved Hide resolved
fondant/component.py Show resolved Hide resolved
@GeorgesLorre
Copy link
Collaborator

Cool stuff, do we need to change more reusable components to use pandas now ?

@RobbeSneyders
Copy link
Member Author

Cool stuff, do we need to change more reusable components to use pandas now ?

They can keep working with the DaskTransformComponent for now, but would indeed propose to update them. There's a ticket to follow this up.

@RobbeSneyders RobbeSneyders merged commit dcd9d74 into main Jun 14, 2023
@RobbeSneyders RobbeSneyders deleted the feature/pandas-interface branch June 14, 2023 20:59
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
Fixes #183 

There's some todo's left, we should
- [ ] Look into the redefinition of the divisions after we clear them.
Now that we take this out of the hands of the user, we should define
which strategy we want to follow here. (#205)
- [ ] Move to `hierarchical columns`. Pandas can work with hierarchical
columns, which would be a lot nicer as a user interface. I want to check
if I can make this work with Dask, and otherwise move the translation
from underscored names to hierarchical columns and back at the level of
the `PandasTransformComponent` (#204)
- [ ] Update the reusable components to leverage the
`PandasTransformComponent` (#203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to Pandas dataframes as interface
4 participants