-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pandas interface #200
Add Pandas interface #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Robbe :) looking nice!
Left a few comments and questions
8251a2d
to
9a68660
Compare
af7cc4f
to
f4034b5
Compare
17e5d34
to
f847f80
Compare
f847f80
to
7bdfbdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Robbe 👍
Cool stuff, do we need to change more reusable components to use pandas now ? |
They can keep working with the |
72ce078
to
44705b0
Compare
Fixes #183 There's some todo's left, we should - [ ] Look into the redefinition of the divisions after we clear them. Now that we take this out of the hands of the user, we should define which strategy we want to follow here. (#205) - [ ] Move to `hierarchical columns`. Pandas can work with hierarchical columns, which would be a lot nicer as a user interface. I want to check if I can make this work with Dask, and otherwise move the translation from underscored names to hierarchical columns and back at the level of the `PandasTransformComponent` (#204) - [ ] Update the reusable components to leverage the `PandasTransformComponent` (#203)
Fixes #183
There's some todo's left, we should
hierarchical columns
. Pandas can work with hierarchical columns, which would be a lot nicer as a user interface. I want to check if I can make this work with Dask, and otherwise move the translation from underscored names to hierarchical columns and back at the level of thePandasTransformComponent
(Provide dataframe with hierarchical columns in PandasTransformComponent #204)PandasTransformComponent
(Update components to implement the PandasTransformComponent #203)