Add build for local components #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgesLorre
requested review from
RobbeSneyders,
PhilippeMoussalli,
NielsRogge and
ChristiaensBert
GeorgesLorre
commented
Jun 14, 2023
tests/example_pipelines/compiled_pipeline/example_2/docker-compose.yml
Outdated
Show resolved
Hide resolved
tests/example_pipelines/compiled_pipeline/example_1/docker-compose.yml
Outdated
Show resolved
Hide resolved
| if component_op.local_component: | ||
| services[safe_component_name][ | ||
| "build" | ||
| ] = f"./{Path(component_op.component_spec_path).parent}" |
There was a problem hiding this comment.
Can the output_path argument be any location on your filesystem? If so, does it make sense to use the "./{Path()}" format or should make it depend on the output_path? I assume the docker-compose up will be ran from the output_path, which could be in a different directory than the local components.
There was a problem hiding this comment.
You mean reference the component code relative from the output_path ?
There was a problem hiding this comment.
Yes, is this needed?
ChristiaensBert
approved these changes
Jun 15, 2023
GeorgesLorre
force-pushed
the
feature/service-build
branch
from
bba7ef5
to
e7397ba
Compare
RobbeSneyders
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.