Migrate stable diffusion & controlnet components to PandasTransformComponent #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
requested review from
GeorgesLorre,
PhilippeMoussalli,
NielsRogge and
ChristiaensBert
NielsRogge
reviewed
Jun 20, 2023
NielsRogge
reviewed
Jun 20, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
…omponent (#219) Contributes to #203 This PR updates the reusable components of the stable diffusion / controlnet pipeline to use the new Pandas interface. I submit these separately since I've already tested them. Some simplifications are clear: - No more `map_partitions` needed for batching - No more `meta` needed for `apply` or similar methods Since we now set the `meta` of the `map_partitions` in the `PandasTransformComponent` based on the component spec, the returned dataframes are validated quite strictly. It does not allow any additional columns. The Pandas implementation can probably be improved further as I'm not the biggest Pandas pro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #203
This PR updates the reusable components of the stable diffusion / controlnet pipeline to use the new Pandas interface. I submit these separately since I've already tested them.
Some simplifications are clear:
map_partitionsneeded for batchingmetaneeded forapplyor similar methodsSince we now set the
metaof themap_partitionsin thePandasTransformComponentbased on the component spec, the returned dataframes are validated quite strictly. It does not allow any additional columns.The Pandas implementation can probably be improved further as I'm not the biggest Pandas pro.