Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage manifest instead of component spec in component data validation #225

Closed
wants to merge 2 commits into from

Conversation

RobbeSneyders
Copy link
Member

This PR does 2 things

  • It leverages the manifest instead of the component spec for data validation in the PandasTransformComponent class. This is better since the output manifest is evolved based on the input manifest and component spec, taking into account things such as additionalSubsets and additionalFields
  • It filters out data not in the manifest from the pandas dataframe returned by the user. Previously, returning additional columns would raise an error. (see [DataComp pipeline] Add first 2 components #223 (comment))

@RobbeSneyders RobbeSneyders requested a review from NielsRogge June 22, 2023 10:26
@RobbeSneyders
Copy link
Member Author

We might not want to use the manifest here after all, since we are validating user code, and they only need to return the code which is explicitly produced by the component. Will revert the manifest change and resubmit the fix for the strict validation.

@RobbeSneyders RobbeSneyders deleted the feature/manifest-data-validation branch January 11, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant