Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't validate returned Pandas dataframe strictly #226

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

RobbeSneyders
Copy link
Member

This PR filters out data from the pandas dataframe returned by the user that is not defined in the component spec. Previously, returning additional columns would raise an error. (see #223 (comment))

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving!

@RobbeSneyders RobbeSneyders merged commit c0b497e into main Jun 23, 2023
@RobbeSneyders RobbeSneyders deleted the feature/no-strict-validation branch June 23, 2023 11:14
RobbeSneyders added a commit that referenced this pull request Jun 26, 2023
Small bug introduced by refactoring after testing #226
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
This PR filters out data from the pandas dataframe returned by the user
that is not defined in the component spec. Previously, returning
additional columns would raise an error. (see
#223 (comment))
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
Small bug introduced by refactoring after testing #226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants