Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM pipeline] Add normalize text component #246

Merged
merged 4 commits into from
Jul 5, 2023
Merged

[LLM pipeline] Add normalize text component #246

merged 4 commits into from
Jul 5, 2023

Conversation

mrchtr
Copy link
Contributor

@mrchtr mrchtr commented Jun 29, 2023

Component which applies different text normalization (nfc, lowercasing and regex pattern replacements)

This component is needed for the LLM dataset creation pipeline.

@mrchtr mrchtr requested a review from NielsRogge June 29, 2023 11:37
@@ -0,0 +1,20 @@
name: Normalize text.
description: A component that normalizes text.
image: ghcr.io/ml6team/text_normalization:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image: ghcr.io/ml6team/text_normalization:latest
image: ghcr.io/ml6team/normalize_text:latest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in chat, agree with consistent naming, but would actually prefer text_normalization here as it will group all text components alphabetically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm not necessarily agree on that one, we can group them ourselves in the docs?

Would prefer to have verb + noun for all our components

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrchtr! One small change is needed to the logging, otherwise LGTM.

@@ -0,0 +1,20 @@
name: Normalize text.
description: A component that normalizes text.
image: ghcr.io/ml6team/text_normalization:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in chat, agree with consistent naming, but would actually prefer text_normalization here as it will group all text components alphabetically.

from fondant.component import PandasTransformComponent
from fondant.logger import configure_logging

configure_logging()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outdated, please rebase on / merge with main.

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrchtr!

@RobbeSneyders RobbeSneyders merged commit b544cd4 into ml6team:main Jul 5, 2023
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
Component which applies different text normalization (nfc, lowercasing
and regex pattern replacements)

This component is needed for the LLM dataset creation pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants