Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM pipeline] Add filter out short texts component #247

Merged
merged 26 commits into from
Jul 11, 2023
Merged

[LLM pipeline] Add filter out short texts component #247

merged 26 commits into from
Jul 11, 2023

Conversation

mrchtr
Copy link
Contributor

@mrchtr mrchtr commented Jun 29, 2023

This component filter out short text passages. Text length can be passed as argument.

This component is needed for the LLM dataset creation pipeline.

@mrchtr mrchtr requested a review from NielsRogge June 29, 2023 11:49
mrchtr and others added 2 commits July 3, 2023 16:29
Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrchtr!

Looks like you'll need to update this branch, as there's currently some conflicts on code that I don't think should be included in this PR (the language_filter component).

Apart from that and some comments to update the component structure to the latest version, it looks good to me.

components/text_length_filter/Dockerfile Outdated Show resolved Hide resolved
components/text_length_filter/requirements.txt Outdated Show resolved Hide resolved
@RobbeSneyders RobbeSneyders merged commit 7f6fd89 into ml6team:main Jul 11, 2023
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
This component filter out short text passages. Text length can be passed
as argument.

This component is needed for the LLM dataset creation pipeline.

---------

Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants