Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redefine empty images array each loop #262

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Redefine empty images array each loop #262

merged 3 commits into from
Jul 4, 2023

Conversation

RobbeSneyders
Copy link
Member

The array of images was not reset in between loops, leading to the same image being set in each component specification.

PhilippeMoussalli
PhilippeMoussalli approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix :)

@RobbeSneyders RobbeSneyders merged commit cb798cb into main Jul 4, 2023
@RobbeSneyders RobbeSneyders deleted the bugfix/build-dev branch July 4, 2023 12:20
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
@RobbeSneyders
Redefine empty images array each loop (#262)
2d6829f 
The array of images was not reset in between loops, leading to the same
image being set in each component specification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeMoussalli PhilippeMoussalli PhilippeMoussalli approved these changes

@GeorgesLorre GeorgesLorre Awaiting requested review from GeorgesLorre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbeSneyders @PhilippeMoussalli