[LLM pipeline] MinHash generation for deduplication #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
There was a problem hiding this comment.
Thanks @mrchtr :)
Looks good overall and thanks for including tests. We should do this for the other components.
Left a few minor comments.
| # Split text into words | ||
| words = text.split() | ||
|
|
||
| # Generate shingles of size 3 using nltk's ngrams function |
There was a problem hiding this comment.
any reason for the having a fixed size of 3? should this be a component parameter?
There was a problem hiding this comment.
Size of 3 is common. But I agree that is indeed better to make it configurable.
PhilippeMoussalli
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Thanks @mrchtr!
Can you just update the docker file to match the latest version?
Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
2 tasks
satishjasthi
pushed a commit
to satishjasthi/fondant
that referenced
this pull request
Jul 21, 2023
This component generates MinHashes of text. The MinHash similarity will be used to determine duplicated text passages. --------- Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com> Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
This component generates MinHashes of text. The MinHash similarity will be used to determine duplicated text passages. --------- Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com> Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component generates MinHashes of text.
The MinHash similarity will be used to determine duplicated text passages.