Bugfix: data explorer artifact mounting #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com>
Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
RobbeSneyders
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Thanks! This works a lot nicer :)
Ran into another issue in the data explorer, but added it to #254
satishjasthi
pushed a commit
to satishjasthi/fondant
that referenced
this pull request
Jul 21, 2023
During the last fix I have incorporate a new bug in mounting the correct path to the docker container. I have adapted the implementation. The path in `fondant explore --data-directory <path>` can also be an relative path now. The path will be resolved to an absolute path. Inside the docker container the folder will be located in the root folder. --------- Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com> Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
During the last fix I have incorporate a new bug in mounting the correct path to the docker container. I have adapted the implementation. The path in `fondant explore --data-directory <path>` can also be an relative path now. The path will be resolved to an absolute path. Inside the docker container the folder will be located in the root folder. --------- Co-authored-by: NielsRogge <48327001+NielsRogge@users.noreply.github.com> Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the last fix I have incorporate a new bug in mounting the correct path to the docker container.
I have adapted the implementation. The path in
fondant explore --data-directory <path>can also be an relative path now.The path will be resolved to an absolute path. Inside the docker container the folder will be located in the root folder.