-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement caching workflow #325
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeMoussalli
force-pushed
the
implement-caching-workflow
branch
from
July 31, 2023 12:31
8d69fa3
to
6ed124d
Compare
PhilippeMoussalli
force-pushed
the
implement-caching-workflow
branch
from
July 31, 2023 15:18
718b7d6
to
78c6574
Compare
PhilippeMoussalli
force-pushed
the
implement-caching-workflow
branch
from
August 1, 2023 07:26
99ab8cb
to
a846678
Compare
PhilippeMoussalli
force-pushed
the
implement-caching-workflow
branch
from
August 1, 2023 07:58
a846678
to
48dba2d
Compare
PhilippeMoussalli
changed the base branch from
main
to
skip-component-run-argument
August 18, 2023 08:56
PhilippeMoussalli
force-pushed
the
implement-caching-workflow
branch
from
August 18, 2023 11:40
abb1ec2
to
03cb144
Compare
RobbeSneyders
pushed a commit
that referenced
this pull request
Aug 22, 2023
PR that creates a metadata class, this will make it easier to implement #368 (was originally part of #325 but decided to break it down to make it easier to review). Few other notable changes: - The `run_id` between both runners has now an identical format (name_timestamp), we no longer need the uid of kfp since it's just used to store the native output artifacts - The `safe_component_name` has been moved from the local runner to the component spec to avoid having to plug it everywhere --------- Co-authored-by: Georges Lorré <35808396+GeorgesLorre@users.noreply.github.com>
Closed in favor of #387 |
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
PR that creates a metadata class, this will make it easier to implement #368 (was originally part of #325 but decided to break it down to make it easier to review). Few other notable changes: - The `run_id` between both runners has now an identical format (name_timestamp), we no longer need the uid of kfp since it's just used to store the native output artifacts - The `safe_component_name` has been moved from the local runner to the component spec to avoid having to plug it everywhere --------- Co-authored-by: Georges Lorré <35808396+GeorgesLorre@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #317
First Review PRs #318 #320
Design discussions #292
PR that implements the general component caching mechanism described in
Few notes:
run-id
when caching since we're checking for existing executions of similar definition based on the manifest and the cache keyMetadata
class since the metadata of the manifest had different schema between both the local and remote runnerartifact
) but we don't write anything to the base oath (custom_artifact
)Pipeline(cache_disabled = True)
. Disabled for remote runner since there is no straightforward method of estimating digests in that workflow (see Add method to estimate caching key #318)*If one component is not cached, then all subsequent components must be re-run/executed
Things to improve in later PRs:
A) Compilation
B) Runtime