-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataComp] Update pipeline name, remove DockerCompiler #340
Conversation
@@ -67,15 +66,7 @@ | |||
pipeline.add_op(load_from_hub_op) | |||
pipeline.add_op(filter_image_resolution_op, dependencies=load_from_hub_op) | |||
pipeline.add_op(filter_complexity_op, dependencies=filter_image_resolution_op) | |||
pipeline.add_op(cluster_image_embeddings_op, dependencies=filter_complexity_op) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cluster image embeddings component won't be used for now, which is why it is removed here.
Isn't this just changing the base path in
I think you can keep the interface and code of the pipeline as is, for now only |
Yes but as I'm switching regularly between both, it's handy to specify both a local and a remote base path rather than having to type it everytime. cc @GeorgesLorre |
b616f42
to
e383385
Compare
0f6b7ea
to
6cfd5cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NielsRogge!
Feel free to approve :) |
I'm working on making the interface for docker and kfp more similar (TBD). But you can alter your pipeline.py already to make this easier:
So if you call your pipeline.py it will assume it is a kfp run and override the base_path and if you use |
This PR updates the pipeline name of DataComp, and makes sure it can run fine both locally and on GCP. Switching between local vs GCP is currently done as follows: - I need to manually comment out the base path I don't want to use - it's either running `fondant run pipeline:pipeline --local` or `python pipeline.py` <img width="391" alt="Screenshot 2023-08-08 at 13 03 05" src="https://github.com/ml6team/fondant/assets/48327001/3fc14f9a-23be-4d0b-bb39-022ae42e69a3">
This PR updates the pipeline name of DataComp, and makes sure it can run fine both locally and on GCP.
Switching between local vs GCP is currently done as follows:
fondant run pipeline:pipeline --local
orpython pipeline.py