Bugfix partitions Load from Hub #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Thanks @PhilippeMoussalli
FYI, you could have used enumerate(dask_df.partitions, start=1) as well 🙂
Oh that's nicer indeed, i'll add it |
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
A fix for loading the dataset when `n_rows_to_load` is specified. An offset of 1 was missing which caused an issue when there was only 1 partition (npartitions from the enumerate started from 0 and an attempt to call `df.head()` with 0 partitions was made)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for loading the dataset when
n_rows_to_loadis specified. An offset of 1 was missing which caused an issue when there was only 1 partition (npartitions from the enumerate started from 0 and an attempt to calldf.head()with 0 partitions was made)