Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip url in download_images before downloading #383

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

RobbeSneyders
Copy link
Member

This should solve a lot of the "invalid non-printable ASCII character in URL" errors

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RobbeSneyders RobbeSneyders merged commit 36973db into main Aug 23, 2023
5 checks passed
@RobbeSneyders RobbeSneyders deleted the bugfix/download-images-non-ascii branch August 23, 2023 20:02
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
This should solve a lot of the "invalid non-printable ASCII character in
URL" errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants