Standarize fsspec file access #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Thanks @PhilippeMoussalli!
Have you been able to test this with remote storage?
yes. Tested locally with a remote storage as base path |
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
PR that standarizes ffspec file access to use the `Abstractfilesystem` class for all filesystem related functionalities. Previously we were using the `Abstractfilesystem` and custom functions `fs_open()` to read/write/list the manifest(s). This caused some issue since `fs_open` expects the protocol of the file system to be present in the URL. However, files returns by `Abstractfilesystem().ls` returned a normal file system url. When passed to `fs_open()` it causes it to fail to read the file properly. Still some issues with using glob patterns. More details here: #368
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that standarizes ffspec file access to use the
Abstractfilesystemclass for all filesystem related functionalities.Previously we were using the
Abstractfilesystemand custom functionsfs_open()to read/write/list the manifest(s). This caused some issue sincefs_openexpects the protocol of the file system to be present in the URL. However, files returns byAbstractfilesystem().lsreturned a normal file system url. When passed tofs_open()it causes it to fail to read the file properly.Still some issues with using glob patterns. More details here: #368