Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image embedding component #428

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Update image embedding component #428

merged 1 commit into from
Sep 12, 2023

Conversation

NielsRogge
Copy link
Contributor

This PR updates the image embedding component, by using the verb + noun format ("image_embedding" => "embed_images"), adding a README and fixing some docstrings.

Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Niels!

@NielsRogge NielsRogge merged commit 98f8740 into main Sep 12, 2023
5 checks passed
@NielsRogge NielsRogge deleted the update_image_embedding branch September 12, 2023 07:58
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
This PR updates the image embedding component, by using the verb + noun
format ("image_embedding" => "embed_images"), adding a README and fixing
some docstrings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants