Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes explorer #446

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Small fixes explorer #446

merged 1 commit into from
Sep 22, 2023

Conversation

PhilippeMoussalli
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli commented Sep 22, 2023

Small PR that:

  • Add pull always policy to the data explore. @Hakimovich99 ran into some issues where the latest image was not pulled (False positive in caching since we're using the latest tag)
  • Fixes issue that @janvanlooy ran into that's related to the volume mounting. Related to Windows (still to be tested if fix actually resolves the issue).

https://stackoverflow.com/questions/50540721/docker-toolbox-error-response-from-daemon-invalid-mode-root-docker

@PhilippeMoussalli PhilippeMoussalli merged commit 5cc1373 into main Sep 22, 2023
5 checks passed
@PhilippeMoussalli PhilippeMoussalli deleted the small-fixes-explorer branch September 22, 2023 12:52
Hakimovich99 pushed a commit that referenced this pull request Oct 16, 2023
Small PR that: 

- Add pull always policy to the data explore. @Hakimovich99 ran into
some issues where the latest image was not pulled (False positive in
caching since we're using the `latest` tag)
- Fixes issue that @janvanlooy ran into that's related to the volume
mounting. Related to Windows (still to be tested if fix actually
resolves the issue).


https://stackoverflow.com/questions/50540721/docker-toolbox-error-response-from-daemon-invalid-mode-root-docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants