Bugfix/sample pipeline cc 25m #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/add-sample-pipeline-cc-25m
| }, | ||
| ) | ||
|
|
||
| # Filter mime type component |
There was a problem hiding this comment.
Why are we removing this one again?
There was a problem hiding this comment.
its not used here but in filter_pipeline.py
There was a problem hiding this comment.
ohh ok thanks :)
PhilippeMoussalli
approved these changes
Sep 25, 2023
GeorgesLorre
approved these changes
Sep 25, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
This PR: - adds the missing fields `surt_url` and `top_level_domain` needed to run the sample CC pipeline - adjusts `n_rows_to_load` to 100k to match the HF dataset card --------- Co-authored-by: Matthias Richter <matthias.r1092@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
surt_urlandtop_level_domainneeded to run the sample CC pipelinen_rows_to_loadto 100k to match the HF dataset card