Improve download images logs #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrchtr
approved these changes
Sep 27, 2023
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
Some of the exception caught by the download images component returned
an empty string since the exception object does not always have a
**string representation** .
Example:
```python
except Exception as e:
logger.warning(f"Skipping {url}: {e)")
```
returns:
```bash
Skipping https://2.gravatar.com/avatar/2d7699b189a0d1e40a506aa3b8cad2dc?s=48&d=identicon&r=G:
```
This makes it difficult to trace back why a url was skipped. Changing to
`repr(e)` seems to fix it since most exeception objects seem to have a
**printable representational string** (at least the httpx ones)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the exception caught by the download images component returned an empty string since the exception object does not always have a string representation .
Example:
returns:
This makes it difficult to trace back why a url was skipped. Changing to
repr(e)seems to fix it since most exeception objects seem to have a printable representational string (at least the httpx ones)