Vertex cli #519
Merged
Vertex cli #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
src/fondant/cli.py
Outdated
| ) | ||
| vertex_parser.add_argument( | ||
| "--project-region", | ||
| help="The project region of the GCP project used to submit the pipeline ", |
There was a problem hiding this comment.
This is on a per pipeline basis right? I tested it and it works. So can we update the help message to reflect hits? Now it seems like the region is tied to the project.
There was a problem hiding this comment.
Indeed this is the region where the pipeline is run and can be different from the project region. Updated the description
PhilippeMoussalli
force-pushed
the
vertex-cli
branch
from
af1b957
to
1c38505
Compare
|
Thanks! You need to update this line from Line 89 in 1c38505 |
RobbeSneyders
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that adds functionalities for compiling and running Vertex Pipelines with the CLI.
After this PR is merged, i'd like to simplify a bit the compilation for both vertex and compile since there is a lot of repetition #517