Refactor compile method for kfp and vertex #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/fondant/compiler.py
Outdated
| @@ -27,6 +27,10 @@ class Compiler(ABC): | |||
| def compile(self, *args, **kwargs) -> None: | |||
| """Abstract method to invoke compilation.""" | |||
|
|
|||
| @abstractmethod | |||
| def set_configuration(self, *args, **kwargs) -> None: | |||
There was a problem hiding this comment.
Any reason to make this a public method?
There was a problem hiding this comment.
Not needed indeed, will revert it
RobbeSneyders
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that refactors the compiler module:
set_configuration()is added as an abstract method since it's implemented in all of the compilerscompile()method is now defined in the kfp compiler and the vertex compiler is now it's child class. Other methods likeresolve_imports()andset_configurationare overridden