Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explorer build script for DockerHub #531

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Fix explorer build script for DockerHub #531

merged 2 commits into from
Oct 18, 2023

Conversation

RobbeSneyders
Copy link
Member

The release pipeline fails on building the explorer script. It was not properly updated for our switch to DockerHub.

Works now: https://hub.docker.com/r/fndnt/data_explorer

PhilippeMoussalli
PhilippeMoussalli approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Robbe, I see that the default namespace in tag_components.sh and tag_explorer.sh is still set to ml6team. Can we also change them to fndnt?

@RobbeSneyders
Copy link
Member Author

Good catch, updated and tested (the explorer one).

@RobbeSneyders RobbeSneyders merged commit b6149f4 into main Oct 18, 2023
6 checks passed
@RobbeSneyders RobbeSneyders deleted the bugfix/explorer-build-script branch October 18, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeMoussalli PhilippeMoussalli PhilippeMoussalli approved these changes

@mrchtr mrchtr Awaiting requested review from mrchtr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobbeSneyders @PhilippeMoussalli