Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add screenshots data explorer #555

Merged
merged 5 commits into from
Oct 27, 2023
Merged

Add screenshots data explorer #555

merged 5 commits into from
Oct 27, 2023

Conversation

mrchtr
Copy link
Contributor

@mrchtr mrchtr commented Oct 26, 2023

fix #496

PhilippeMoussalli
PhilippeMoussalli approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@PhilippeMoussalli PhilippeMoussalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks Matthias

RobbeSneyders
RobbeSneyders requested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrchtr!

One small typo in one of the urls. Also, I think we can use relative urls here, which should be a bit more robust.

Can you also move the Data Explorer UI section to the top and the How to use? to the bottom?

docs/data_explorer.md Outdated Show resolved Hide resolved
mrchtr and others added 2 commits October 27, 2023 15:06
@mrchtr @RobbeSneyders
Update docs/data_explorer.md
60d1ffa 
Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
@mrchtr
Move data explorer UI section
58cb3cb
@mrchtr
Copy link
Contributor Author

mrchtr commented Oct 27, 2023

Also, I think we can use relative urls here, which should be a bit more robust.

Not sure if this will work. The images where broken some weeks ago. Then we started to replace the relative links with the urls to the images.

@RobbeSneyders
Copy link
Member

Not sure if this will work. The images where broken some weeks ago. Then we started to replace the relative links with the urls to the images.

This should only be the case on the main page, since we insert the README there and the urls need to be relevant to different directories on the site vs Github.

@RobbeSneyders RobbeSneyders merged commit e388a45 into main Oct 27, 2023
@RobbeSneyders RobbeSneyders deleted the add-screenshot-data-explorer branch October 27, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbeSneyders RobbeSneyders RobbeSneyders approved these changes

@PhilippeMoussalli PhilippeMoussalli PhilippeMoussalli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add screenshots to the data explorer documentation
3 participants
@mrchtr @RobbeSneyders @PhilippeMoussalli