Datacomp submission improvement #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrchtr
reviewed
Oct 31, 2023
| @@ -11,7 +11,7 @@ RUN pip3 install --no-cache-dir -r requirements.txt | |||
|
|
|||
| # Install Fondant | |||
| # This is split from other requirements to leverage caching | |||
| ARG FONDANT_VERSION=main | |||
| ARG FONDANT_VERSION=0.6.2 | |||
There was a problem hiding this comment.
Should we really change the Dockerfile? I think we can fix the version by using the fondant build command, right?
There was a problem hiding this comment.
right I just saw the build args command, I will revert it back
RobbeSneyders
approved these changes
Oct 31, 2023
| @@ -1,6 +1,6 @@ | |||
| name: Filter CLIP score | |||
| description: Component that filters out bad captions (Empty captions, Captions with weird characters, Captions that are dates) | |||
| image: fndnt/filter_clip_score:dev | |||
| image: fndnt/filter_clip_score:0.6.2 | |||
There was a problem hiding this comment.
We'll have to check if we still want to use the fndnt registry for the custom components in the examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that updates the datacomp pipeline setting to be reusable. After this PR is merged, I will move the datacomp to a separate repo