Split component and pipeline SDKs #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
requested review from
mrchtr,
GeorgesLorre and
PhilippeMoussalli
PhilippeMoussalli
approved these changes
Oct 31, 2023
| @@ -27,7 +28,7 @@ def build_sidebar(base_path: str) -> Tuple[Manifest, str, Dict[str, str]]: | |||
| Tuple[Optional[str], Optional[str], Optional[Dict]: Tuple with manifest path, | |||
| subset name and fields | |||
| """ | |||
| fs = get_filesystem(base_path) | |||
| fs, _ = fsspec.core.url_to_fs(base_path) | |||
| ) | ||
| from fondant.pipeline import Pipeline | ||
| from fondant.runner import DockerRunner, KubeflowRunner, VertexRunner | ||
| if t.TYPE_CHECKING: |
There was a problem hiding this comment.
what does this do?
There was a problem hiding this comment.
It only imports the guarded imports during type checking, not at runtime. See docs.
GeorgesLorre
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #554
This PR splits the component and pipeline SDKs. Some things I want to add in follow-up PRs: